Commit Diff

Commit:
7ddea6c5284750e02983e76f44f19c65e51c638a
From:
Omar Polo <op@omarpolo.com>
Date:
Message:
use snprintf(3) instead of a strlcpy/cat dance
Actions:
Patch | Tree
commit - 0fe9ac228cc8e9b9115a6b613ddbb87589335180
commit + 7ddea6c5284750e02983e76f44f19c65e51c638a
blob - b2d692a8829abc7ab0d9265416fed802d4bcb868
blob + d9d93d8cd1dd71a0264ce9b35878ceff67b93cd9
--- minibuffer.c
+++ minibuffer.c
@@ -638,8 +638,6 @@ void
 minibuffer_read(const char *prompt, void (*fn)(const char *, struct tab *),
     struct tab *data)
 {
-	size_t len;
-
 	if (in_minibuffer)
 		return;
 
@@ -648,9 +646,7 @@ minibuffer_read(const char *prompt, void (*fn)(const c
 	enter_minibuffer(read_self_insert, read_select, read_abort,
 	    read_history, NULL, NULL, 0);
 
-	len = sizeof(ministate.prompt);
-	strlcpy(ministate.prompt, prompt, len);
-	strlcat(ministate.prompt, ": ", len);
+	snprintf(ministate.prompt, sizeof(ministate.prompt), "%s: ", prompt);
 }
 
 static void